Prepare DrFed for collaborative development by dahlia · Pull Request #14 · fedify-dev/drfed

dahlia · 2026-06-20T15:25:44Z

This pull request sets up the project so other contributors can work against the same local workflow, package boundaries, and contribution rules.

It adds the first installable server and model packages, wires the GraphQL layer to the database schema, and gives contributors a documented path for building, running, formatting, and reviewing changes.

What changed

Added @drfed/models, including the Drizzle schema for accounts, instances, and instance members, database type exports, email normalization, migration support, and the initial generated migration under packages/models/drizzle.
Added @drfed/drfed, the main server package with the drfed-server npm binary, Optique-based CLI parsing, PGlite and PostgreSQL database options, automatic migration support, and GraphQL Yoga serving through srvx.
Expanded @drfed/graphql with a Pothos schema builder, Drizzle integration, Relay node support, DateTime, Email, and UUID scalars, Account and Instance object types, and an accountByUuid query.
Replaced the inline dev task with scripts/dev.mts, which cleans package dist directories, starts recursive tsdown --watch builds, waits for the packages to build, starts the server, and handles shutdown more reliably.
Added the contributor guide in CONTRIBUTING.md, with AGENTS.md and CLAUDE.md pointing to it, so people and coding agents read the same project instructions.
Added formatting and workspace support through mise.toml, pnpm-workspace.yaml, .oxfmtrc.json, .hongdown.toml, and editor settings under .zed/settings.json.

Checks

mise run check
mise run build

AI disclosure

scripts/dev.mts and CONTRIBUTING.md were written with GPT-5.5 assistance. The README.md file in each package was written with Claude Sonnet 4.6. assistance. The scripts/bump-versions.mts and scripts/check-versions.mts were written with GLM-5.2 assistance. No AI assistance was used for the other changes in this pull request.

- New @drfed/models package with Drizzle ORM schema defining accounts, instances, and instance_members tables (PostgreSQL), with support for both PGlite (local file-based) and PostgreSQL backends, plus database/transaction type definitions and an initial migration - New @drfed/drfed package: main server CLI using srvx and GraphQL Yoga, with @optique-based argument parsing for database backend selection (--pglite-data-path or --postgres-url), listen address (--listen), and migration control (--no-migrate) - Expanded @drfed/graphql with a Pothos SchemaBuilder integrated with the Drizzle plugin for type-safe GraphQL schema generation, and a createYogaServer() factory function wiring it all together - Added .oxfmtrc.json formatter config and .zed/settings.json with per-language format-on-save via oxfmt - Updated mise.toml and pnpm workspace to include the new packages

- Add @pothos/plugin-relay and graphql-scalars dependencies - Add DateTime, Email, UUID custom scalar types to the schema builder - Rename PothosTypes to SchemaTypes and add Scalars definition - Implement Account drizzleNode with UUID, email, created fields - Add accountByUuid query field - Refactor Instance to drizzleNode with slug, expires, created fields - Add normalizeEmail() utility function to @drfed/models - Export normalizeEmail from @drfed/models package index

Replace the Nushell-based dev task with a Node.js/TypeScript script (scripts/dev.mts) that provides more robust process management: - Remove dist directories before starting builds - Spawn tsdown in watch mode across all packages - Poll until all packages have built their dist directories - Start the drfed server once builds are ready - Propagate SIGINT/SIGTERM gracefully to child process groups, with a 5-second timeout before force-killing - Handle double Ctrl+C with an immediate forced kill - Cross-platform support (Windows taskkill, Unix process groups) Also handle SIGINT (in addition to SIGTERM) in the server's main() to ensure clean shutdown when running under node --watch. Assisted-by: Codex:gpt-5.5

Document the DrFed development workflow, including mise-based tasks, package boundaries, AGPL source headers, npm packaging expectations, and AI usage disclosure rules. Point AGENTS.md and CLAUDE.md at the same guide, and exclude those symlinks from Hongdown so Markdown checks validate the source document once. Assisted-by: Codex:gpt-5.5

Add package-level tsconfig files with strict no-emit type checking and allowImportingTsExtensions enabled for local .ts imports. Wire Node 26 types through the pnpm catalog, add the mise type check, and update imports that must be type-only under verbatimModuleSyntax. Also fix the development script's child-process error result typing and process lookup error handling so it passes the stricter checks.

2chanhaeng

Looks great! The code and the flow seem solid. I think it would be even better if more documentation for the code were added.

CONTRIBUTING.md: descriptions for each package
README.md for each package
- @drfed/models: descriptions for each model and their relationships
- @drfed/graphql: descriptions for each node

https://mise.jdx.dev/configuration.html#minimum-mise-version fedify-dev#14 (comment) fedify-dev#14 (comment)

fedify-dev#14 (comment) fedify-dev#14 (comment)

fedify-dev#14 (comment)

Added a concise README.md to each of the three packages: - packages/drfed/README.md: documents the CLI options, server startup behavior, and source file layout for @drfed/drfed. - packages/graphql/README.md: documents the custom scalars, source layout, and createYogaServer usage for @drfed/graphql. - packages/models/README.md: documents the database schema, source layout, and migration generation for @drfed/models. Added a Packages section to CONTRIBUTING.md with a table summarising each package's directory path, npm name, and one-line description. Also added README.md to the files list in each package.json so the documentation is included in published npm packages. Assisted-by: Claude Code:claude-sonnet-4-6

fedify-dev#14 (comment)

sij411

Could you also change my email in packages to work@kwonjiwon.org ?

2chanhaeng · 2026-06-21T23:58:23Z

+  "accounts",
+  {
+    id: uuid().primaryKey(),
+    email: varchar({ length: 255 }).notNull().unique(),


I might be misunderstanding something, but since the same email can be used across multiple instances, wouldn't it be non-unique? Also, if for virtual accounts, wouldn't it be more efficient not to have an email at all, so making it nullable would be better?

I guess you're misunderstanding what this accounts table is for. It represents DrFed accounts who creates instances, not instance actors who belong to an instance.

Hmm... OK, now that's clear. But then, I can't understand why the name of the relation table between the accounts and the instances is instance_members. I think instance_creator or ⁦instance_owner (@sij411's idea) is easier to understand.

fedify-dev#14 (review)

fedify-dev#14 (comment)

Add scripts/check-versions.mts and scripts/bump-versions.mts along with corresponding mise tasks (check:versions and bump) to keep the shared `version` field across all packages/*/package.json in sync. check:versions is wired into the check:* group so it runs as part of `mise run check` and fails when any package diverges, reporting which packages are at which versions. `mise run bump <version>` updates every package's version field at once and prints a summary of the changes. Document the shared-version policy and the new commands in CONTRIBUTING.md under a new "Version management" section, and list the sync check among the checks run by `mise run check`. fedify-dev#14 (comment) Assisted-by: OpenCode:glm-5.2

https://mise.jdx.dev/configuration.html#minimum-mise-version #14 (comment) #14 (comment)

#14 (comment) #14 (comment)

#14 (comment)

#14 (review)

#14 (comment)

Prepare DrFed for collaborative development

dahlia · 2026-06-22T05:56:22Z

Rebased by mistaken; replace commits with merge commit d2141f9.

dahlia added 5 commits June 20, 2026 23:33

dahlia requested a review from a team June 20, 2026 15:25

dahlia self-assigned this Jun 20, 2026

dahlia added this to NLnet NGI0 Commons Fund (2026) Jun 20, 2026

github-project-automation Bot moved this to Todo in NLnet NGI0 Commons Fund (2026) Jun 20, 2026

dahlia moved this from Todo to In progress in NLnet NGI0 Commons Fund (2026) Jun 20, 2026

2chanhaeng reviewed Jun 20, 2026

View reviewed changes

Comment thread .zed/settings.json

Comment thread mise.toml

Comment thread CONTRIBUTING.md

Comment thread packages/graphql/src/account.ts

Comment thread packages/models/src/schema.ts

dahlia added 3 commits June 21, 2026 11:40

Specify mise's min_version

26fe6a4

https://mise.jdx.dev/configuration.html#minimum-mise-version fedify-dev#14 (comment) fedify-dev#14 (comment)

Add some missing docs

73567a5

fedify-dev#14 (comment) fedify-dev#14 (comment)

VS Code settings and use proper version of oxfmt

737e456

fedify-dev#14 (comment)

dahlia requested review from 2chanhaeng, dodok8 and sij411 June 21, 2026 03:10

dahlia added this to the DrFed 0.1.0 milestone Jun 21, 2026

dahlia linked an issue Jun 21, 2026 that may be closed by this pull request

Setting up the repository #1

Closed

Clarify the difference between accounts and actors

93625ff

fedify-dev#14 (comment)

2chanhaeng previously approved these changes Jun 21, 2026

View reviewed changes

sij411 requested changes Jun 21, 2026

View reviewed changes

Comment thread packages/models/src/schema.ts Outdated

Comment thread packages/drfed/package.json Outdated

dodok8 reviewed Jun 21, 2026

View reviewed changes

Comment thread packages/models/tsconfig.json

Comment thread packages/drfed/package.json

2chanhaeng reviewed Jun 21, 2026

View reviewed changes

dahlia added 5 commits June 22, 2026 11:14

Use Jiwon's work email address

296342b

fedify-dev#14 (review)

Properly configure a composite primary key

f2a5fcf

fedify-dev#14 (comment)

Export Drizzle record types

d88f1a1

Typo: engines, not engine

2a0c0ca

fedify-dev#14 (comment)

Extract common tsconfig.json settings

6b098b7

fedify-dev#14 (comment)

dahlia dismissed 2chanhaeng’s stale review via bdadeaf June 22, 2026 03:43

dahlia requested review from 2chanhaeng, dodok8 and sij411 June 22, 2026 03:46

sij411 approved these changes Jun 22, 2026

View reviewed changes

2chanhaeng approved these changes Jun 22, 2026

View reviewed changes

dahlia removed the request for review from dodok8 June 22, 2026 05:51

dahlia merged commit f8e7518 into fedify-dev:main Jun 22, 2026

dahlia added a commit that referenced this pull request Jun 22, 2026

Specify mise's min_version

3065287

https://mise.jdx.dev/configuration.html#minimum-mise-version #14 (comment) #14 (comment)

dahlia added a commit that referenced this pull request Jun 22, 2026

Add some missing docs

6dfcbb4

#14 (comment) #14 (comment)

dahlia added a commit that referenced this pull request Jun 22, 2026

VS Code settings and use proper version of oxfmt

880e236

#14 (comment)

dahlia added a commit that referenced this pull request Jun 22, 2026

Clarify the difference between accounts and actors

3033b2b

#14 (comment)

dahlia added a commit that referenced this pull request Jun 22, 2026

Use Jiwon's work email address

8116dd5

#14 (review)

dahlia added a commit that referenced this pull request Jun 22, 2026

Properly configure a composite primary key

a6efb06

#14 (comment)

dahlia added a commit that referenced this pull request Jun 22, 2026

Typo: engines, not engine

4899aa6

#14 (comment)

dahlia added a commit that referenced this pull request Jun 22, 2026

Extract common tsconfig.json settings

86e2f04

#14 (comment)

github-project-automation Bot moved this from In progress to Done in NLnet NGI0 Commons Fund (2026) Jun 22, 2026

dahlia added a commit that referenced this pull request Jun 22, 2026

Merge pull request #14 from dahlia/main

d2141f9

Prepare DrFed for collaborative development

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare DrFed for collaborative development#14

Prepare DrFed for collaborative development#14
dahlia merged 16 commits into
fedify-dev:mainfrom
dahlia:main

dahlia commented Jun 20, 2026 •

edited

Loading

Uh oh!

2chanhaeng left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sij411 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

2chanhaeng Jun 21, 2026

Uh oh!

dahlia Jun 22, 2026

Uh oh!

2chanhaeng Jun 22, 2026

Uh oh!

dahlia commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dahlia commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Checks

AI disclosure

Uh oh!

2chanhaeng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sij411 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

2chanhaeng Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

dahlia Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

2chanhaeng Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

dahlia commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dahlia commented Jun 20, 2026 •

edited

Loading